bug-parted
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] libparted: fix a bug in the hfs probe functions (#714758


From: Jim Meyering
Subject: Re: [PATCH 1/3] libparted: fix a bug in the hfs probe functions (#714758)
Date: Mon, 17 Oct 2011 21:26:22 +0200

Brian C. Lane wrote:

> On Sat, Oct 15, 2011 at 11:29:07AM +0200, Jim Meyering wrote:
>>
>> Hi Brian,
>>
>> This looks like a fine bug fix.
>> Can you write a test suite addition that
>> creates an HFS file system and then corrupts
>> it in a way that triggers the bug?
>
> I don't think I can, I don't think we have any way to construct a valid
> HFS filesystem to run the test against.

I see mkfs.hfs in the hfsplus-tools package.

There's already a function you can use to check for existence of the program:

require_hfs_()
{
  mkfs.hfs 2>&1 | grep '^usage:' \
    || skip_ "This test requires HFS support."
}



reply via email to

[Prev in Thread] Current Thread [Next in Thread]