Re: Parted (GIT) error with 140-entries GPT table

[Jim Meyering]

Jim Meyering wrote:

> Keshav P R wrote:
>
>> Strange. Parted is able to open/print a manually created dd image (with 140
>> entry gpt table created using gdisk) but the "make check" test fails (http://
>> paste2.org/p/1758285) . Whats wrong?
>
> Thanks for the report.
> The new script that's run by that test uses Perl's Digest/CRC.pm module:
>
>     Can't locate Digest/CRC.pm in @INC (@...
>
> On an rpm-based system, you can install it with this:
>
>     yum install -y perl-Digest-CRC
>
> I'll adjust the test to skip (with a warning) rather than
> to fail when that package is not available.

FYI, I've just addressed that with this patch:

>From c52cf0b120b0767009dd13be1e90dd12b4198641 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 10 Nov 2011 19:15:29 +0100
Subject: [PATCH] tests: skip a test if Perl's Digest::CRC module is not
 installed

* tests/init.cfg (require_perl_digest_crc_): New function.
* tests/t0210-gpt-resized-partition-entry-array.sh: Use it.
Reported by Keshav P R in
http://thread.gmane.org/gmane.comp.gnu.parted.bugs/10530/focus=10589
---
 tests/init.cfg                                   |   10 ++++++++++
 tests/t0210-gpt-resized-partition-entry-array.sh |    1 +
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/tests/init.cfg b/tests/init.cfg
index c5fbb5e..3109454 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -31,6 +31,16 @@ require_udevadm_settle_()
     || skip_ 'udevadm command is required for this test'
 }

+require_perl_digest_crc_()
+{
+  local ok=0
+  local t
+  t=$(perl -le 'use Digest::CRC qw(crc32); print crc32("123")') \
+    && test $t = 2286445522 && ok=1
+  test $ok = 1 \
+    || skip_ "this test requires Perl's Digest::CRC module"
+}
+
 # We need two cleanup functions.  One, cleanup_final_, is sometimes
 # used (transparently) via t-local.sh's modprobe/rmmod code.
 # The other is used e.g., to unmount.
diff --git a/tests/t0210-gpt-resized-partition-entry-array.sh 
b/tests/t0210-gpt-resized-partition-entry-array.sh
index c3d3ee2..7c8b57f 100755
--- a/tests/t0210-gpt-resized-partition-entry-array.sh
+++ b/tests/t0210-gpt-resized-partition-entry-array.sh
@@ -17,6 +17,7 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.

 . "${srcdir=.}/init.sh"; path_prepend_ ../parted $srcdir
+require_perl_digest_crc_

 ss=$sector_size_

--
1.7.8.rc0.61.g8a042