[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22266: [libparted] jump instruction and boot code is corrupted with
bug#22266: [libparted] jump instruction and boot code is corrupted with random bytes after fat is resized
Sun, 10 Apr 2016 14:00:33 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
Attached is a patch to fix the issue with jump instruction and boot code
is corrupted with random bytes after fat is resized.
Thanks goes to Tom Yan, Dirk Eberhardt, and others who reported the
problem and provided additional details. This detailed information
helped with my understanding of the issue.
The portion of this email after my signature delves further into the
problem investigation and solution.
Windows does not recognize FAT32 after resizing with utilities (for
example GParted) that use parted-3.2 libraries.
Steps to confirm are:
1) Create a single FAT32 partition (e.g. 500 MiB) on a device such as
a USB drive.
When I created FAT32 partition using GParted the boot sector
$ sudo hexdump -n 7k -C /dev/sda1
00000000 eb 58 90 6d 6b 66 73 |.X.mkfs|
2) Use GParted linked with parted-3.2 libraries to shrink the FAT32
partition (e.g. 450 MiB).
After FAT32 resizing using GParted the boot sector started with:
$ sudo hexdump -n 7k -C /dev/sda1
00000000 d0 02 30 4d 53 57 49 |..0MSWI|
The important distinction is that the first three hexadecimal
values were randomly changed. These values represent the "boot
jump" code and Windows requires these values to be correctly set.
3) Try to use the FAT32 partition with Windows (e.g. insert USB drive
in Windows computer). The FAT32 file system is not recognized.
Regarding boot_jump (and system_id) see:
If the libraries from parted 3.1, or versions 2.4 and earlier are
used, then the resized FAT32 partition is recognized by Windows.
The problem with Windows FAT32 recognition was introduced with:
Fix filesystem detection on non 512 byte sectors
The cause of the problem is that when the parted library is resizing
FAT32, there is one too many boot_sector memory allocations.
The calling structure is as follows:
ctx = create_resize_context (...); # Allocates new boot_sector
# memory and copies content
# from old boot sector
fat_boot_sector_generate (...) # Allocates new boot_sector
# memory AGAIN!
# Copied content lost!
Remove new boot sector memory allocation from
The function fat_boot_sector_generate(...) is also called from
Note that access to fat_create(...) via ped_file_system_create(...)
is no longer possible since parted-3.0 because all file system
operations were removed. See:
In parted-3.1, access to fat_create(...) via
ped_file_system_create(...) was not re-introduced. See:
Although fat_create(...) in inaccessible, I thought it best to move
the new boot_sector memory allocation to where it is needed in
fat_boot_sector_set_boot_code(...). That way the code should still
work if it is ever re-instated.
GNU bug report logs - #22266:
[libparted] jump instruction and boot code is corrupted with random
bytes after fat is resized
GNU bug report logs - #22710:
libparted 3.2 fat32 bootsector incompatible w. windows
GParted Bug Report:
Bug 759916 - fat(32) resizing generates boot sector(s) with invalid
jump instruction and pseudo-random boot code
Vista/XP don't accept a shrinked Fat32 partition (USB-stick)
Description: Text Data
- bug#22266: [libparted] jump instruction and boot code is corrupted with random bytes after fat is resized,
Curtis Gedak <=