[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-patch] Re: patch troubles with CRLF's again

From: Andreas Gruenbacher
Subject: Re: [bug-patch] Re: patch troubles with CRLF's again
Date: Mon, 16 Mar 2009 19:34:59 +0100
User-agent: KMail/1.9.9

On Sunday, 15 March 2009 23:33:18 Karl Berry wrote:
>     How about new files though --- which line ending to use there?
> Follow the host system.
>     When running on a UNIX system, IMHO patch should try to by a good
>     citizen and default to UNIX semantics rather than creating files
>     with CRLF line endings. (Unless told otherwise, of course.)
> I agree.  But the "creating" caveat is important -- when patching an
> *existing* file, I think it is (much) better to follow the convention of
> the existing source file, independent of the host system.

Mind that in cases like Mike's, we would still end up with mixed line endings 
in new vs. existing files.  This is not as bad as mixed line endings within a 
file, but it's still broken.  Requiring to turn off the trailing CR heuristic 
explicitly on the command line prevents this aberration.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]