bug-patch
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-patch] outfile not initialized


From: Jack Andrews
Subject: [bug-patch] outfile not initialized
Date: Mon, 17 Aug 2009 16:40:16 -0500

hi guys,

i've been looking through the patch source, and AFAICT, the
'outfile' variable is only initialized in option parsing but it
seems to be used in a few places where it is uninitialized.

i'm likely wrong, but here's my analysis:

$ grep -r outfile *.[ch]
common.h:XTERN char *outfile;
patch.c:    init_output (outfile, 0, &outstate);
patch.c:      char *outname = outfile ? outfile : inname;
patch.c:        if (! dry_run && ! outfile)
patch.c:        if (! skip_rest_of_patch && ! outfile)
patch.c:                  if (outstate.ofp && ! outfile)
patch.c:                if (outfile)
patch.c:      if (! skip_rest_of_patch && ! outfile) {
patch.c:                outfile = savestr (optarg);
patch.c:    if (outstate->ofp && ! outfile)
pch.c:                int readonly = outfile && strcmp (outfile, name[i]) != 0;

ta, jack.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]