Re: [bug-patch] GNU patch 2.6.1 fails to build on IRIX

[Andreas Gruenbacher]

Stuart,

thanks for the bug report.

On Friday 15 January 2010 17:17:56 Stuart Shelton wrote:
> On IRIX (and, indeed, any platform without strnlen() or strndup()),
> patch 2.6.1 fails [...] because 'config.h' says that 'HAVE_DECL_STRNDUP' and
> 'HAVE_DECL_STRNLEN' should be set to '0' or '1' depending on whether
> the function is available, but then the code in these two files checks
> to see whether HAVE_DECL_STRNDUP and HAVE_DECL_STRNLEN are defined -
> which will always be the case.

Fixed.

> patch 2.6.1 also runs into the infamous MIPSpro error:
> 
> cc-1999 cc: ERROR File = src/bestmatch.h, Line = 135
>  "jumping out of a block containing VLAs" is not currently implemented

This is a compiler bug but I'm fine with a workaround it in the code.  The 
same construct is used all over the place -- I have replaced all instances.

ftp://alpha.gnu.org/gnu/patch/patch-2.6.1-9-gf376c5d.tar.gz includes these two 
fixes.

Thanks,
Andreas