[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-patch] [PATCH] do not validate target name when it is specified

From: Andreas Gruenbacher
Subject: Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line
Date: Wed, 16 Feb 2011 12:16:34 +0100
User-agent: KMail/1.13.5 (Linux/; KDE/4.4.4; x86_64; ; )

On Wednesday 16 February 2011 09:56:00 Jim Meyering wrote:
> > Here's a patch that implements what I have in mind.  Do you really think
> > that this approach is too unsafe?
> As I said: "slightly...".  No big deal.

Okay, let's go with what I have plus your review comments then.

I have uploaded a new snapshot with this fix to 


> When viewing the above using a fixed-width font, and 8-space
> TAB stops shows why using mixed TABs and spaces for indentation
> is bad.  It makes the patch much harder to read.
> Have you considered indenting only with spaces?
> I've made that the policy in a few projects, and it
> has worked well.

No, I haven't considered that.  My editor introduces tabs all by itself in 
some operations.  I generally apply patches before reviewing them; that has 
worked well enough so far.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]