[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-patch] patch >= 2.6 silently ignores hunks

From: Andreas Grünbacher
Subject: Re: [bug-patch] patch >= 2.6 silently ignores hunks
Date: Fri, 6 Sep 2013 23:50:00 +0200

2013/9/6 Pádraig Brady <address@hidden>:
>> Patch doesn't recognize the hunk in this case, it treats everything
>> after line 8 of tempname.diff as garbage. The parser either requires
>> an explicit file name or a patch header (the --- and +++ lines in
>> unified format) followed by a number of valid hunks; everything else
>> is treated as "garbage".
> Even if it's another hunk in the same file?

Yes, it doesn't know that it's supposed to still be in the same file.

>> It's not so hard to make patch recognize such hunks again, but
>> then it will more easily misinterpret other text as part of a patch --
>> it's not so clear that things would improve.
> OK I understand the tradeoffs, but in this case
> it's very surprising that patch ignores the hunk marker on line 9

I agree.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]