[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-patch] Incorrect error when applying git-created patch

From: Tim Waugh
Subject: Re: [bug-patch] Incorrect error when applying git-created patch
Date: Tue, 12 Aug 2014 09:42:12 +0100

On Mon, 2014-08-11 at 18:58 +0200, Andreas Grünbacher wrote:
> With a binary patch, it succeeds:
> $ git show --binary | git apply
> Patch doesn't currently support git binary patches, it only recognizes them.

Thanks, this example makes things clearer.

> > Shouldn't it just delete the file in this instance?
> The current behavior seems reasonable to me -- better safe than sorry.
> The message could be improved though.

I'm not sure. The message makes sense to me now.

Maybe 'Binary files ... differ' could be spotted, and if it appears
after 'deleted file mode ...' a warning like "not deleting binary file
as content may differ" could be emitted?


Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]