bug-patch
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-patch] [PATCH] Drop useless test in another_hunk()


From: Jean Delvare
Subject: [bug-patch] [PATCH] Drop useless test in another_hunk()
Date: Mon, 10 Nov 2014 11:27:57 +0100

This test will always succeed so it is either broken or useless. The
equivalent code path for context patches doesn't have this test so I
suppose it's OK to just remove it.
---
 src/pch.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/src/pch.c
+++ b/src/pch.c
@@ -1651,7 +1651,7 @@ another_hunk (enum diff difftype, bool r
        if (*s == ' ') s++;
        if (*s++ != '@')
            malformed ();
-       if (*s++ == '@' && *s == ' ' && *s != '\0')
+       if (*s++ == '@' && *s == ' ')
          {
            p_c_function = s;
            while (*s != '\n')


-- 
Jean Delvare
SUSE L3 Support



reply via email to

[Prev in Thread] Current Thread [Next in Thread]