[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-patch] lin should be ssize_t, not off_t
From: |
Andreas Grünbacher |
Subject: |
Re: [bug-patch] lin should be ssize_t, not off_t |
Date: |
Sun, 30 Nov 2014 16:16:07 +0100 |
Tobias,
2014-11-24 19:51 GMT+01:00 Tobias Stoeckmann <address@hidden>:
> as the subject says, lin should be ssize_t instead of off_t. This
> works on Linux systems I have seen, because sizeof(size_t) is basically
> always sizeof(off_t). I don't know if there are 32 bit Linux systems
> with a 64 bit off_t ...
this depends on the _FILE_OFFSET_BITS macro.
> Without such a switch, way too large lins are parsed without errors,
> exceeding limits in various parts of the source.
Shouldn't we instead fix the code where it is currently broken?
Thanks,
Andreas