[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-readline] Re: PATCH: PR tui/2173: Arrow keys no longer works in bre
[Bug-readline] Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list
Tue, 28 Nov 2006 12:14:30 -0500
On Tue, Nov 28, 2006 at 08:58:44AM -0800, H. J. Lu wrote:
> On Tue, Nov 28, 2006 at 11:46:58AM -0500, Daniel Jacobowitz wrote:
> > On Tue, Nov 21, 2006 at 01:32:05PM -0800, H. J. Lu wrote:
> > > The problem is callback in readline 5.1 is changed. When gdb readline
> > > callback calls readline (), readline is really confused since although
> > > it is called from gdb callback, it isn't really in callback state. This
> > > kludge seems to work for me.
> > I'm pretty sure this isn't right. I got as far as figuring out that we
> > should be calling rl_callback_handler_install and
> > rl_callback_handler_remove at different times, always removing the
> > handler before calling readline recursively, but I couldn't quite work
> > out the right conditions.
> I assume by "this isn't right", you mean my patch may break something.
> Do you have a testcase? It may get into readline:
I don't think it's right because it's messing around with the internals
of readline from GDB. If it's applied to readline that's an entirely
different story; then it looks like a fine fix.
With the version Jan sent to bug-readline, I worry that readline and GDB
will get confused if we longjmp out of the readline handler; you can
make that happen by typing:
(gdb) define foo