[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-readline] Issue with colored-stats option with readline-6.3-rc1 on

From: Martin Wesdorp
Subject: [Bug-readline] Issue with colored-stats option with readline-6.3-rc1 on Ubuntu 10.04.4LTS
Date: Tue, 10 Dec 2013 22:39:31 +0100
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130330 Thunderbird/17.0.5


I am doing some tests with the new colored-stats feature in readline-6.3-rc1 on an Ubuntu 10.04 LTS system. The new feature is enabled by adding "set colored-stats on" in the inputrc file. When readline() is then called from my app (sqsh) and initalizes, it throws an error:

readline: LS_COLORS: unrecognized prefix: hl
readline: unparsable value for LS_COLORS environment variable

When I use filename completion then, the output is garbled with some strange control characters after the printed filenames. The problem is that my system uses the prefix "hl" for hardlinked files in LS_COLORS instead of "mh". The output of dircolors shows:

export LS_COLORS

So the fourth entry specifies the "hl" prefix for hardlinked files that should be shown as white on blue. However, readline-6.3-rc1 expects the prefix "mh" for hardlinked filenames. When I modify the $LS_COLORS environment variable and change "hl" to "mh", then readline works great, but then 'ls' starts to complain that it doesn't understand the "mh" prefix. When I modify the code of readline and change the occurences of "mh" to "hl" in the appropriate places then everything works fine again. But on some of my other systems like Cygwin and CentOS the "mh" prefix is correct and "hl" is unknown. So probably the best solution would be to add an additional "hl" entry to the _rl_color_indicator[] array and indicator_name[] lists.

The reason that I get garbage data when I use filename completion after _rl_parse_colors() fails, is due to the fact that this function frees the _rl_color_ext_list of $LS_COLORS entries when it runs into an unknown entry, but does not disable the feature by setting _rl_colored_stats to 0. In file complete.c the function print_filename() still makes calls to colored_stat_start() and colored_stat_end() then and does not print the correct LEFT and RIGHT combination of colorcode control characters, I think. Wouldn't it be better by the way for _rl_parse_colors() to just ignore an unknown entry in $LS_COLORS instead of discarding all?

Thanks in advance for considering a fix for this issue.

Best regards,
Martin Wesdorp.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]