Re: [Bug-readline] build failure with readline 6.3 and python, samba and parted

[Max Horn]

On 03.03.2014, at 20:19, Chet Ramey <address@hidden> wrote:

> On 3/3/14 1:04 PM, Juergen Daubert wrote:
>> Hello,
>> 
>> after installing the new readline 6.3 I rebuild a couple of packages 
>> on my system (Linux, gcc 4.7.3, glibc 2.16.0) and get errors for the 
>> following:
> 
> Yes, those old-style function typedefs have been deprecated for a couple
> of releases now.  I finally removed them in readline-6.3.

Late reply, but: This is a bit unfortunate, as it constitutes an API breakage. 
I just got a bug report about this because me updating the Fink readline6 
package to 6.3.3 broke our python package. So now I'll have to patch the header 
to add back the typedef.

Thing is, while this typedef may have been deprecated for a couple of releases, 
there was no real means for client code to notice this, was there? 

So, perhaps they could be added back for now, but with a twist: add 
__attribute__((deprecated)); to them, at least for compilers that support it 
(gcc, clang). And also say clearly that these will be released in readline 7 
(which will be free to break API and ABI, I assume).


#if !defined (_FUNCTION_DEF)
#  define _FUNCTION_DEF

#if defined(__GNUC__) || defined(__clang__)
typedef int Function () __attribute__ ((deprecated));
typedef void VFunction () __attribute__ ((deprecated));
typedef char *CPFunction () __attribute__ ((deprecated));
typedef char **CPPFunction () __attribute__ ((deprecated));
#else
typedef int Function ();
typedef void VFunction ();
typedef char *CPFunction ();
typedef char **CPPFunction ();
#endif

#endif /* _FUNCTION_DEF */


Cheers,
Max

signature.asc
Description: Message signed with OpenPGP using GPGMail