[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-readline] [PATCH] Enable visibility annotations
From: |
Mike Frysinger |
Subject: |
Re: [Bug-readline] [PATCH] Enable visibility annotations |
Date: |
Thu, 14 Apr 2016 03:46:22 -0400 |
On 14 Apr 2016 09:45, Yury Gribov wrote:
> -extern void using_history PARAMS((void));
> +extern READLINE_EXPORT void using_history PARAMS((void));
since READLINE_EXPORT must be defined regardless, why not fold "extern"
into it too ?
> --- a/rlstdc.h
> +++ b/rlstdc.h
> @@ -54,4 +54,8 @@
> # endif
> #endif
>
> +#if defined(__GNUC__) && (__GNUC__ >= 4) && !defined(__CYGWIN__) &&
> !defined(__MINGW32__)
> +#define READLINE_EXPORT __attribute__((visibility("default")))
> +#endif
it seems you forgot to define READLINE_EXPORT in the negative case,
so all the builds go boom :).
that said, what's with the extensive cpp checks ? you already did a
configure test for it, so you should just re-use that logic and have
it set something up in config.h or add to CPPFLAGS.
-mike
signature.asc
Description: Digital signature
- [Bug-readline] [PATCH] Enable visibility annotations, Yury Gribov, 2016/04/14
- [Bug-readline] [PATCH] Enable visibility annotations, Yury Gribov, 2016/04/14
- Re: [Bug-readline] [PATCH] Enable visibility annotations,
Mike Frysinger <=
- Re: [Bug-readline] [PATCH] Enable visibility annotations, Pedro Alves, 2016/04/14
- Re: [Bug-readline] [PATCH] Enable visibility annotations, Yury Gribov, 2016/04/14
- Re: [Bug-readline] [PATCH] Enable visibility annotations, Mike Frysinger, 2016/04/14
- Re: [Bug-readline] [PATCH] Enable visibility annotations, Yury Gribov, 2016/04/14
- Re: [Bug-readline] [PATCH] Enable visibility annotations, Yury Gribov, 2016/04/14
- Re: [Bug-readline] [PATCH] Enable visibility annotations, Mike Frysinger, 2016/04/14
- Re: [Bug-readline] [PATCH] Enable visibility annotations, Chet Ramey, 2016/04/15
- Re: [Bug-readline] [PATCH] Enable visibility annotations, Pedro Alves, 2016/04/14
- Re: [Bug-readline] [PATCH] Enable visibility annotations, Yury Gribov, 2016/04/14