[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-readline] [PATCH 1/1] readline: patch to correct linker flag sequen
From: |
Nimesh Prajapati |
Subject: |
[Bug-readline] [PATCH 1/1] readline: patch to correct linker flag sequence |
Date: |
Wed, 15 Nov 2017 01:21:00 -0600 |
From: Yogesh Prasad <address@hidden>
Description
This patch will correct the sequence of -pie and -shared options.
When used together, -pie should be provided to the linker before
-shared. If -pie is provided after -shared, the linker throws an
error shown below as example.
The patch fixes Makefile.am for below libs within setools:
- libhistory.so.7.0
- libreadline.so.7.0
-------------------------------------------------------------------------
/host/powerpc-buildroot-linux-gnu/sysroot/usr/lib/Scrt1.o:(.data+0x4):
undefined reference to `main'
/host/lib/gcc/powerpc-buildroot-linux-gnu/6.4.0/../../../..
/powerpc-buildroot-linux-gnu/bin/ld: BFD (GNU Binutils) 2.28.1
assertion fail elf32-ppc.c:8923
collect2: error: ld returned 1 exit status
make[3]: *** [libhistory.so.7.0] Error 1
make[3]: *** Waiting for unfinished jobs....
mv vi_mode.o vi_mode.so
mv complete.o complete.so
mv bind.o bind.so
mv display.o display.so
make[2]: *** [shared] Error 2
make[1]: *** [/build/readline-7.0/.stamp_built] Error 2
make: *** [_all] Error 2
-------------------------------------------------------------------------
Signed-off-by: Yogesh Prasad <address@hidden>
Signed-off-by: Matt Weber <address@hidden>
---
shlib/Makefile.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/shlib/Makefile.in b/shlib/Makefile.in
index f2ec3e4..7c01859 100644
--- a/shlib/Makefile.in
+++ b/shlib/Makefile.in
@@ -174,11 +174,11 @@ unsupported:
$(SHARED_READLINE): $(SHARED_OBJ)
$(RM) $@
- $(SHOBJ_LD) ${SHOBJ_LDFLAGS} ${SHLIB_XLDFLAGS} -o $@ $(SHARED_OBJ)
$(SHLIB_LIBS)
+ $(SHOBJ_LD) ${SHLIB_XLDFLAGS} ${SHOBJ_LDFLAGS} -o $@ $(SHARED_OBJ)
$(SHLIB_LIBS)
$(SHARED_HISTORY): $(SHARED_HISTOBJ) xmalloc.so xfree.so
$(RM) $@
- $(SHOBJ_LD) ${SHOBJ_LDFLAGS} ${SHLIB_XLDFLAGS} -o $@ $(SHARED_HISTOBJ)
xmalloc.so xfree.so $(SHLIB_LIBS)
+ $(SHOBJ_LD) ${SHLIB_XLDFLAGS} ${SHOBJ_LDFLAGS} -o $@ $(SHARED_HISTOBJ)
xmalloc.so xfree.so $(SHLIB_LIBS)
# Since tilde.c is shared between readline and bash, make sure we compile
# it with the right flags when it's built as part of readline
--
1.9.1
- [Bug-readline] [PATCH 1/1] readline: patch to correct linker flag sequence,
Nimesh Prajapati <=