[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24615: [PATCH] sed: handle the patterns which consist of ^ or $ manu

From: Norihiro Tanaka
Subject: bug#24615: [PATCH] sed: handle the patterns which consist of ^ or $ manually
Date: Wed, 19 Oct 2016 07:45:29 +0900

On Mon, 17 Oct 2016 20:25:57 -0400
Assaf Gordon <address@hidden> wrote:

> Hello Norihiro,
> Thank you for the updates.
> On top of the patches you've sent, I suggest these two minor additions. We 
> can squash them into your patch before the final commit.
> The first adds the required 'memrchr' gnulib module, which is not available 
> in non-gnu libc.
> The second adds few lines of comments for the begline/endline conditionals, 
> as I feel the sed code in general is a bit opaque and hard to understand. Of 
> course I'd appreciate if you review my comments and ensure they are true to 
> the code.
> The last thing I'd like to add (and hope to complete by the end of the week) 
> is to add tests to cover the new code (especially the new code for dfa/-z 
> interaction).
> Once completed, we can squash it all into one patch and commit.
> WDYT ?
> regards,
>  - assaf

Hi Assaf,

Thanks for reviewing and adjusting the patch.  Your understanding is
right for the patch, and I agree to your all changes.

I updated two tests for testing this change.


Attachment: 0001-sed-update-tests-for-previos-change.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]