bug-sed
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#22460: 'y' command doesn't allow a comment after it one the same lin


From: Assaf Gordon
Subject: bug#22460: 'y' command doesn't allow a comment after it one the same line
Date: Fri, 27 Jan 2017 03:04:27 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

Hello Thorsten,

Sorry for the delayed response.

On Mon, Jan 25, 2016 at 02:28:22AM +0100, Thorsten Heymann wrote:
Unlike other commands, the current implementation of the 'y' command does
not allow a comment on the same line if the command is not
"terminated" by a ';'

That is indeed a bug, and a rather old one.

Your suggested fix is correct, but I thought that instead of
duplicating the same few lines, it might be better to extract
the code to a new function.

The attached patch does that and adds a corresponding unit test.

Comments welcomed,
- assaf


Attachment: 0001-sed-allow-comments-braces-after-y.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]