[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-stow] some minor errors in stow's Makefile.am

From: Adam Spiers
Subject: Re: [Bug-stow] some minor errors in stow's Makefile.am
Date: Tue, 6 Dec 2011 20:43:46 +0000

On Tue, Dec 6, 2011 at 7:34 PM, Stefano Lattarini
<address@hidden> wrote:
> Hi Adam, hope you don't mind another minor nitpick ...

Not at all, your expertise is very welcome!

> On Tuesday 06 December 2011, Adam Spiers wrote:
>> On Tue, Dec 6, 2011 at 12:30 PM, Stefano Lattarini
>> <address@hidden> wrote:
>> > Hi!
>> >
>> > While looking in stow's Makefile.am, I've noticed few minor errors
>> > and blunders, and I think you might want to know about them.
>> Many thanks for this review Stefano, it's hugely helpful!  I will fix
>> these and make a new release.
> I still see this in stow's Makefile.am:
>  CLEANFILES = $(bin_SCRIPTS) $(pm_DATA) $(dist_man_MANS) $(HTML) $(PDF) 
> ChangeLog
> which means that the distributed files $(dist_man_MANS), $(HTML), $(PDF)
> and ChangeLog will still be removed by "make clean".  IMHO the following
> would be better:
>  MAINTAINERCLEANFILES = $(dist_man_MANS) $(HTML) $(PDF) ChangeLog

Yes, I actually made that change a few hours ago after a user
discovered that `make distclean' broke `make install' for them.

> Also, the dependencies:
>  dist-hook: $(dist_man_MANS) ChangeLog
>  ChangeLog: doc/ChangeLog.OLD
> will not ensuere that the ChangeLog will be remade at "make dist"
> time, even if it is out-of-date w.r.t. the current git repository.

Yep, but at least it ensures it's there :-) I did add a note to
doc/HOWTO-RELEASE reminding me to `rm ChangeLog' before `make
distcheck' but on second thoughts, automating it would be better ...

> The following should offer a workaround, by forcing ChangeLog to
> be rebuilt unconditionally upon creation of distribution tarballs
> (untested!):
>  dist-hook: $(dist_man_MANS)
> ## If we are creating a distribution from a git checkout, ensure
> ## the ChangeLog file is in sync the git repository.
>        if test -d $(top_srcdir)/.git; then \
>          rm -f ChangeLog \
>            && $(MAKE) $(AM_MAKEFLAGS) ChangeLog \
>            && cp -f ChangeLog $(distdir)/ChangeLog; \
>        else :; fi;

I did consider the recursive make, but it felt kinda ugly.  Having
said that it's probably better than nothing.

Thanks a lot!

P.S. any idea on this?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]