Re: [Bug-sysutils] Updated patch for chage.c

[tao]

Quoting Barry deFreese <address@hidden>:

> Hello AGAIN.. :-)
> 
> OK, I have revised my code for chage.c  I can now build it without any 
> errors but I get "Illegal Operation (core dumped)" running chage.. :-(

I suspect it might be because of the changes to the passing of usernames.

> I'll look into that but if someone gets a chance to review these changes 
> I would appreciate it.

I've had a brief look at your changes now.

The different indentation of @return as compared to @param is because I want
the end of the works to align rather than the beginning of the words.

I still haven't written a proper template yet, so there is no automated
generation of documentation from those headers; when so happens, the looks of
the comments will probably be altered anyway.

Rule A of patch-submission is to follow the coding style of the rest of the
project.  Choose an arbitrary .c-file in the project, read it, compare the
coding style to your newly introduced functions/structs/etc, and make
proper changes.  Or, if you prefer to, leave that to me when I merge the
changes.  Either way is fine with me.

> I promise once I get a better understanding of all of this I won't ask 
> for so much input. :-(

Asking for input is *under*-estimated.  Asking for input from others is a
virtue, not a sin. If nothing else, it might stop people from implementing
things like STREAMS and animated paper clips... =P

Meanwhile, here in La-La land, I've been working on lastlog (finished)
and wall (almost there) and watched Monty Python's Flying Circus (bought
the complete series on DVD...), fixed various typos in the manual-pages,
fixed incorrect comments, made a lot of changes that will be rendered useless
by your argp-stuff =), killed the idea of implementing faillog, and done
various other minor cleanup.

Anyway, I'll go home again, finish up wall, then try to merge your argp-changes
to chage (minus the USERS-changes, for earlier mentioned reasons), and report
my results here on Monday or Tuesday...


Regards: David Weinehall