Re: [Bug-sysutils] argp patch for cppw.c

[Marco Gerards]

Barry deFreese <address@hidden> writes:

> OK, here are the argp changes for cppw.c.  It builds and seems to work
> properly.  I'm getting a little better.. :-)

Great!

> +     case 'p':
> +             if (args->passwd == 0) {
> +                     fprintf(stderr,
> +                             _("%s: `-p' cannot be combined with `-g'\n"
> +                               "Try `%s --help' for more information.\n"),
> +                             progname, progname);
> +                     return -1;

Please correct me if I am wrong, but IIRC the return type of this
function is error_t.  Better use a macro (EINVAL perhaps?) instead of
-1.  Another thing you might want to do is calling `argp_usage'.

--
Marco