bug-tar
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-tar] Symlink extraction broken w/recent CVS versions


From: Paul Eggert
Subject: Re: [Bug-tar] Symlink extraction broken w/recent CVS versions
Date: Thu, 31 May 2007 16:39:27 -0700
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

"MrC" <address@hidden> writes:

> This doesn't seem appropriate, and is going to bite a lot of software
> distributors and builders.

I agree.  It appears to be a bug introduced in this patch:

        2007-03-30  Sergey Poznyakoff  <address@hidden>

                * src/common.h (transform_name_fp): Change signature
                (transform_member_name): New function
                * src/extract.c (extract_link, extract_symlink): Use
                transform_member_name instead of safer_name_suffix so that
                --transform and --strip-components affect links as well.
                * src/list.c (transform_member_name): New function
                (decode_header): Use transform_member_name
                * src/names.c (all_names_found): Remove check for 
matching_flags.
                * NEWS: Update

                * TODO: Update
                * bootstrap (slurp): Remove any occurrences of $bt from the
                generated gnulib.mk
                * src/incremen.c: Do not include mkdtemp.h

As your example shows, it's not so simple as blindly applying
--strip-components values to every link that comes in.  Perhaps
absolute links should be stripped, but certainly a relative symbolic
link within the tree should not be stripped.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]