Re: [Bug-tar] error handling and exit code (patch for tar-1.20/1.21)

[John Hein]

Sergey Poznyakoff wrote at 11:13 +0200 on Mar  4, 2009:
 > Solar Designer <address@hidden> ha escrit:
 > 
 > > I'd like to submit upstream a patch from Openwall GNU/*/Linux that we
 > > came up with in Nov-Dec 2008, and which we've extensively tested since
 > > then
 > 
 > Thanks a lot. These are very reasonable changes. I have one doubt,
 > though: are you sure that a file disappearing from under the running tar
 > can be treated as unimportant error, especially when in incremental backup
 > mode?

I've been using this patch locally to avoid the troublesome exit error
on 'file changed' if --ignore-failed-read is used...

===========================
As recently as 1.15.1, --ignore-failed-read used to prevent tar from
exiting with non-zero exit status for 'file changed'.

--- src/create.c.orig   Mon Apr 14 06:03:12 2008
+++ src/create.c        Thu Sep  4 11:22:31 2008
@@ -1658,7 +1658,8 @@
            {
              WARN ((0, 0, _("%s: file changed as we read it"),
                     quotearg_colon (p)));
-             if (exit_status == TAREXIT_SUCCESS)
+             if (exit_status == TAREXIT_SUCCESS
+                 && ! ignore_failed_read_option)
                exit_status = TAREXIT_DIFFERS;
            }
          else if (atime_preserve_option == replace_atime_preserve
===========================