bug-tar
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-tar] error handling and exit code (patch for tar-1.20/1.21)


From: Solar Designer
Subject: Re: [Bug-tar] error handling and exit code (patch for tar-1.20/1.21)
Date: Mon, 17 Aug 2009 09:30:28 +0400
User-agent: Mutt/1.4.2.3i

Hi Sergey,

On Sat, Aug 08, 2009 at 08:00:21PM +0300, Sergey Poznyakoff wrote:
> Current git master implements the functionality proposed by your
> posting on 2009-03-29.  It is partially based on your patch.
[...]
> Would you please test it and inform me if it needs any further
> improvements?

I've updated the Owl package of tar to 1.22.90 with some patches, and
I've installed that on a couple of systems where incremental backups are
done nightly.  We'll see how it performs.  I intend to slowly deploy it
(or a newer version) on more systems.

While making this update, I've reviewed your changes against my older
tar-1.20-owl-error-handling.diff patch.  It appears that you missed(?)
two hunks: one in create.c: dump_regular_file() and the other in
incremen.c: scan_directory().  Additionally, I think that the call to
dir_removed_diag() in scan_directory() should pass cmdline, not false,
for top_level.  I've attached a patch fixing these three issues.

As usual, our current tar patches are available at:

http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/tar/

Thanks,

Alexander

Attachment: tar-1.22.90-owl-error-handling.diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]