bug-tar
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-tar] [PATCH] Don't inhibit large file support.


From: Sergey Poznyakoff
Subject: Re: [Bug-tar] [PATCH] Don't inhibit large file support.
Date: Sat, 06 Feb 2010 23:33:01 +0200

Eric Blake <address@hidden> ha escrit:

> tar should always use fseeko, not fseek, to avoid arbitrary limits
> on 32-bit platforms.

Yes, it should. Thanks for the patch. However, I'd say it's second
part:

> -  if (fseek (fp, 0L, SEEK_SET) != 0)
> +  if (fseeko (fp, 0L, SEEK_SET) != 0)

is superfluous. When searching for 0, it makes no difference which
function to use.

Regards,
Sergey







reply via email to

[Prev in Thread] Current Thread [Next in Thread]