bug-tar
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-tar] Tar 1.23 patch proposed to enable symlink timestamp restor


From: Eric Blake
Subject: Re: [Bug-tar] Tar 1.23 patch proposed to enable symlink timestamp restoration
Date: Mon, 26 Apr 2010 08:34:11 -0600
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b1 Thunderbird/3.0.4

On 04/23/2010 11:33 AM, MELENNEC Ronan DGAC/CEDRe wrote:
> My patch only changes tar-1.23/src/extract.c :
> - a test on file type barring symlink timestamps
> from being restored is removed ;
> - a call to utimens() is replaced by a call to lutimens().

We might as well use gnulib's wrapper lutimens that correctly wraps
utimensat, and provides as much resolution as possible on as many
platforms as possible.  After all, that's what coreutils 8.4 is doing in
its implementation of touch -h.

> Limitations :
> - as of today I can only test on Linux Ubuntu 9.10
> (using a 2.6.31 kernel) ;
> - I have not thoroughly analysed the relevant configuration
> scripts.
> Therefore I cannot make any assessment of portability.

Using gnulib for the time-setting functions guarantees the portability,
insofar as gnulib is able to provide it.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]