[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-tar] Tar short read

From: Paul Eggert
Subject: Re: [Bug-tar] Tar short read
Date: Wed, 28 Sep 2011 08:09:41 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20110831 Thunderbird/3.1.13

On 09/28/11 00:15, Andreas Dilger wrote:
> That said, looking more closely at the rest of the code, I see that
> a function called full_rw() already exists that calls safe_rw()

Yes, a better fix is for tar to use gnulib's full-read module.
That's already on my list of things to do.  As we've
mentioned, though, it's not high priority.

Such a change would be trivial,
except that one must carefully think through all replacements of
safe_read and full_read and decide whether full_read is really
appropriate.  When this part of tar was written, I already considered
this issue and decided that safe_read was better, but I've forgotten
all the pros and cons and need to go back and re-derive them.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]