[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] POSIX_ARCHIVE & big sparse files (>= 2^33 B excluding hole
Re: [Bug-tar] POSIX_ARCHIVE & big sparse files (>= 2^33 B excluding holes)
Mon, 28 Jan 2013 17:40:46 +0100
On Mon, 2013-01-28 at 14:59 +0100, Pavel Raiskup wrote:
> On Mon, 2013-01-28 at 10:17 +0100, Pavel Raiskup wrote:
> > Hi Paul,
> > > Thanks for catching that bug. We don't yet have a facility
> > > for large test cases, so I guess we can put that on the todo list.
> > I agree (this is probably about paxutils?).
> > > Your patch doesn't feel quite right, as there's a similar
> > > issue in pax_dump_header_0, and also there's a problem if
> > > the shrunken size is less than 8 GiB but the real size is not.
> > > I pushed the following patch instead: does it fix things for you?
> > Of course, it fixes the issue. Thanks for this!
> Another small problem: tar is unable to list such archive (containing
> sparse file(s) of size >8GB). It does not honor the size=N extended
> header during reading. This is because the file_stat->archive_file_size
> is set based on basic header field only before xheader_decode() is
> Could you consider/use as inspiration the following fix? Thanks.
Re-sending patch with added comments (attached).
Description: Text Data