[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-tar] --sparse is broken on filesystems where small files may ha

From: Pavel Raiskup
Subject: Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks
Date: Tue, 29 Oct 2013 15:10:24 +0100
User-agent: KMail/4.11.2 (Linux/3.11.6-200.fc19.x86_64; KDE/4.11.2; x86_64; ; )

> To be clear, I can see that the fix to ST_IS_SPARSE should cause
> dump_regular_file to be called instead of sparse_dump_file, but I still
> wonder if it is wise to leave this logic in place.  At the very last,
> I think a comment would be helpful to explain that this test is valid
> only because ST_IS_SPARSE has already succeeded.

At least for the check for zero blocks in sparse file:  It is intentional
because it makes the processing of completely sparse files to be done in
constant time (try to archive 'file' from `truncate -s 10G file`).  This
could be documented possibly.  Otherwise, I would not say that there is
unclear that sparse_dump_file is supposed to be called only against real
sparse files.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]