Re: [Bug-tar] Appending file(s) to tar file may silently fail

[Pavel Raiskup]

On Wednesday 12 of November 2014 16:01:52 Hendrik Grewe wrote:
> If one tries to append a file to an existing .tar file through
> 
>   tar --append --file defective.tar fileToAdd.xxx
> 
> tar may return exit code 0 and terminate without error though the
> fileToAdd.xxx is not added to the .tar file. However the tarfile has
> been changed in some kinde since md5sums of defective.tar befor the
> non working call and after the call differ.
> [...]
> The defective tar file (generated by pg_basebackup) may be found here:
> 
> https://depot.tu-dortmund.de/get/8aq4g
> 
> If you need any further information feel free to contact me.

Thanks for the report.  The archive is not aligned to record_size (which
is not an issue, just the issue trigger).  You may test the first attached
patch.

The second patch should just avoid unnecessary busy reading of seek-able
archives.

Pavel

0001-Fix-unaligned-archive-corruption-with-append.patch
Description: Text Data

0002-Allow-seeking-in-archive-with-append.patch
Description: Text Data