|
From: | Pavel Raiskup |
Subject: | Re: [Bug-tar] Circular symlinks lead to segfault |
Date: | Sun, 15 Nov 2015 15:01:38 +0100 |
User-agent: | KMail/4.14.10 (Linux/4.2.5-300.fc23.x86_64; KDE/4.14.14; x86_64; ; ) |
On Friday 13 of November 2015 16:13:49 Pavel Raiskup wrote: > On Friday 13 of November 2015 15:34:09 Pavel Raiskup wrote: > > On Friday 27 of March 2015 10:24:39 Sergey Poznyakoff wrote: > > > Paul Eggert <address@hidden> ha escrit: > > > > > > > Thanks for reminding me. Sergey, have you had a chance to look at the > > > > latest iteration of that patch? > > > > > > It slipped my attention somehow. I'm revising it now. > > > > Any progress on this? > > > > $ mkdir test-segfault > > $ cd test-segfault/ > > $ mkdir d > > $ ln -s ../d d/d > > $ tar chf /dev/null d > > Segmentation fault (core dumped) > > > > Fix was proposed here: > > https://www.mail-archive.com/address@hidden/msg04542.html > > https://lists.gnu.org/archive/html/bug-tar/2014-07/msg00013.html > > Uh, not applicable patches. I've updated those and now re-attaching. > There are two unexpected passes I need to look at yet. Ok, latest patch: commit e6fcc73efa7463fe20c30a20603d3a3f6abfd4e5 (origin/master, origin/HEAD) Author: Sergey Poznyakoff <address@hidden> Work around unlinkat bug on FreeBSD and GNU/Hurd wasted some hours of my free time (fixed the same issue with remfiles0{8,9}b I mentioned here as unexpected passes) .. This patch (workaround) which came in the meantime I don't feel is completely fine anyway -- issues like that (bug in library call) should be fixed within gnulib; I would like to see that reverted. It is good as downstream patch for BSD, I agree. Anyway, I rebased again, hopefully we can process those soon. I've attached also patch 0003- that fixes the infinite recursion for incremental archives. Pavel
0001-tar-avoid-recursion-in-directory-traversal.patch
Description: Text Data
0003-incremen-don-t-indefinitely-recurse-into-symlink-loo.patch
Description: Text Data
0002-create-do-not-segfault-with-dereference.patch
Description: Text Data
testsuite.log.xz
Description: application/xz
[Prev in Thread] | Current Thread | [Next in Thread] |