Re: [Bug-tar] tar-1.31/lib/stdopen.c:63]: (style) Suspicious condition

[David Binderman]

Hello there,

---

>That's changing the written meaning. 

Indeed. Deliberately.

The code isn't clear, so I guessed at what the code was trying to do.

I might be wrong.

As currently written, new_fd isn't a new file descriptor, it is a boolean value, even though it's type is int.

If all the code wanted was a boolean value, why bother with an int ?

I suggest looking at the code again, with a view to re-work to make it's intention clear.

Brackets and appropriate types for local variables can help make the code more close

to the original intention.

Regards

David Binderman