[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gendocs.sh bug

From: Eric Blake
Subject: Re: gendocs.sh bug
Date: Fri, 17 Sep 2010 09:21:39 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100907 Fedora/3.1.3-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.3

On 07/21/2010 04:20 PM, Karl Berry wrote:
Hi Eric,

Thanks for the report, as always.

     tar: Removing leading `/' from member names

Yes, it is true.

     It looks like this portion of gendocs.sh should be using tar's -C option

I don't mind using -C (people with deficient tar's shouldn't be using
gendocs.sh anyway :), but it didn't seem quite that simple to me when I
looked at a while ago, but I don't remember what the issue was.  If you
care to look into it, so much the better, else I will get to it as soon
as I have a chance.  Can't be too deep.

I finally got around to this, since I need it before releasing autoconf 2.68. It turns out that: 1) we don't need tar -C to make this work after all, and 2) you already assume GNU tar, because the script was using 'tar -czf' at one point; traditional tar neither accepts leading - on options nor understands the -z option for creating gzip'd archives.

At any rate, here's the patch:

2010-09-17  Eric Blake  <address@hidden>

        * util/gendocs.sh: Fix usage when outdir is absolute or contains

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: gendocs.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]