[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: texinfo-5.9.90 pretest available

From: Gavin Smith
Subject: Re: texinfo-5.9.90 pretest available
Date: Tue, 24 Feb 2015 19:29:34 +0000

> Next, "make check" fails because info/pseudotty.c cannot be possibly
> compiled on Windows (and I'm not sure how portable it is to Posix
> platforms, either).  This is bad news for the MinGW port, because most
> of the Info brand-new test suite will not run.  I found and ran all
> the non-interactive tests by hand, but it would be nice if (1) there
> were a way to at least run those non-interactive tests automatically
> where pseudotty cannot be used; and (2) how about including in the
> scripts that implement interactive tests instructions for running them
> manually?  I think being able to run the tests on any supported
> platform is important.

Here's a fix to skip these tests. The test in configure.ac may not
manage to exclude Cygwin, considering that Ken managed to compile
pseudotty under Cygwin - suggestions are welcome.

 $svn diff ../configure.ac Makefile.am t/Init-inter.inc
Index: ../configure.ac
--- ../configure.ac     (revision 6150)
+++ ../configure.ac     (working copy)
@@ -167,9 +167,12 @@
 # that anyone compiling new texinfo still has such a thing? we'll see.
 AC_CHECK_FUNCS(bzero getcwd memset setlocale setvbuf sigaction sigprocmask \
-               sigsetmask strchr)
+              sigsetmask strchr posix_openpt)
 AC_REPLACE_FUNCS(memcpy memmove strdup strerror)

+# Used for Info tests
+AM_CONDITIONAL([have_ptys], [test x$ac_cv_func_posix_openpt = xyes])
 # We want to recognize djgpp to avoid the useless warning about no
 # term library.
Index: Makefile.am
--- Makefile.am (revision 6135)
+++ Makefile.am (working copy)
@@ -78,8 +78,10 @@

 # Test suite

+if have_ptys
 check_PROGRAMS = pseudotty
 pseudotty_SOURCES = pseudotty.c

 TESTS = \
        t/file.sh \
Index: t/Init-inter.inc
--- t/Init-inter.inc    (revision 6047)
+++ t/Init-inter.inc    (working copy)
@@ -16,6 +16,9 @@
 # Initialize test of interactive operation
 # This file is to be sourced, not run directly

+# Skip test if pseudotty wasn't built
+test -x pseudotty || exit 77
 # Avoid ginfo complaining that terminal is too dumb
 TERM=vt100; export TERM

On 24 February 2015 at 17:55, Ken Brown <address@hidden> wrote:
> It compiles on Cygwin but apparently doesn't work the way it should. All the
> interactive tests either hang or time out.  I ended up editing
> info/Makefile.am and removing all the interactive tests, so that I could run
> "make check".
> I then found quite a few tests that failed, but I haven't yet had a chance
> to look into these failures.
> Ken

It hung for me as well when I removed the pseudotty executable.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]