bug-texinfo
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: change in tests requires running autogen.sh


From: Gavin Smith
Subject: Re: change in tests requires running autogen.sh
Date: Wed, 4 Jan 2023 19:44:57 +0000

On Wed, Jan 04, 2023 at 08:26:04PM +0100, Patrice Dumas wrote:
> > The result file index_table.txt is present in
> > t/results/indices/index_table/res_plaintext/ but not in out_plaintext.
> > Should this file be generated by the test or should the reference file
> > be removed?
> 
> A file in out_plaintext should be generated, the
> t/results/indices/index_table/res_plaintext/index_table.txt file looks
> good to me.  Maybe look at the errors in
> t/results/indices/index_table.pl.new?

It is present as a directory:


$ diff t/results/indices/index_table.pl{,.new}
7824a7825,7834
> $result_converted_errors{'file_plaintext'}->{'index_table'} = [
>   {
>     'error_line' => 'could not open 
> t/results/indices/index_table/out_plaintext/index_table.txt for writing: Is a 
> directory
> ',
>     'text' => 'could not open 
> t/results/indices/index_table/out_plaintext/index_table.txt for writing: Is a 
> directory',
>     'type' => 'error'
>   }
> ];
> 
> 

$ ls t/results/indices/index_table/out_plaintext/index_table.txt/
indices-refs.txt                 node-with-printindex.txt
node-with-ftable-and-vtable.txt  Top.txt

After I do

$ rm -r t/results/indices/index_table/out_plaintext/

the test passes.  These must have been stale results from an older
version of the test.

> > There are also changes to tp/Makefile.tres after building and running the
> > tests:
> 
> These added directories res_latex look wrong.  Theses tests are in
> @test_formatted, and the latex test is 'latex' which should only lead to
> content in the .pl file, like t/results/indices/empty_index_entry.pl.
> (There should be a res_latex if the test is file_latex).

> > Should these be committed?
> 
> I don't think so.  The res_html in t/results/raw/displaymath looks wrong
> too.

I'll see if these changes come back.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]