Re: Fix an error during "./configure; make dist"

[Bruno Haible]

Hi Gavin,

> Thanks for the fixes; I have committed them to "master" in your name
> with minor modifications.  I have checked that "make dist" works without
> "make" being run first.

There are two problems with commit cd7a003d9fce67866745e718ff97e09ad689cf3c:

1) The ChangeLog entry regarding info/Makefile.am is duplicated.

2) "make distcheck" fails. (Reported by the weekly CI. It was fine a week ago.)

How to reproduce:
$ git pull
$ ./autogen.sh
$ ./configure CPPFLAGS="-Wall"
$ make
$ make check
$ make distcheck
...
ERROR: files left in build directory after distclean:
./doc/tp_api/texi2any_internals.texi
./doc/tp_api/api_includes/Texinfo-Convert-Plaintext.texi
./doc/tp_api/api_includes/Texinfo-Transformations.texi
./doc/tp_api/api_includes/Texinfo-Document.texi
./doc/tp_api/api_includes/Texinfo-OutputUnits.texi
./doc/tp_api/api_includes/Texinfo-Convert-HTML.texi
./doc/tp_api/api_includes/Texinfo-Indices.texi
./doc/tp_api/api_includes/Texinfo-ManipulateTree.texi
./doc/tp_api/api_includes/Texinfo-Commands.texi
./doc/tp_api/api_includes/Texinfo-Convert-NodeNameNormalization.texi
./doc/tp_api/api_includes/Texinfo-Convert-Info.texi
./doc/tp_api/api_includes/Texinfo-Report.texi
./doc/tp_api/api_includes/Texinfo-Convert-TexinfoMarkup.texi
./doc/tp_api/api_includes/Texinfo-Structuring.texi
./doc/tp_api/api_includes/Texinfo-Convert-Unicode.texi
./doc/tp_api/api_includes/Texinfo-Convert-Utils.texi
./doc/tp_api/api_includes/Texinfo-Common.texi
./doc/tp_api/api_includes/Texinfo-Convert-Text.texi
./doc/tp_api/api_includes/Texinfo-Convert-TexinfoXML.texi
./doc/tp_api/api_includes/Texinfo-Parser.texi
./doc/tp_api/api_includes/Texinfo-Convert-Texinfo.texi
./doc/tp_api/api_includes/Texinfo-Convert-DocBook.texi
./doc/tp_api/api_includes/Texinfo-Translations.texi
./doc/tp_api/api_includes/Texinfo-Convert-Converter.texi
make[1]: *** [Makefile:2213: distcleancheck] Error 1
make[1]: Leaving directory '/TEXINFO/texinfo/texinfo-7.1.90/_build/sub'
make: *** [Makefile:2142: distcheck] Error 1

The problem is that these files, while present in the tarball, have been
regenerated in the build dir. But the GNU Coding Standards
<https://www.gnu.org/prep/standards/html_node/Makefile-Basics.html>
specify that such files should be regenerated in the source dir.
This eliminates possible confusion between the same file being present
(in different versions) in the source dir and in the build dir.

The attached patch fixes it. Tested.

Bruno

0001-build-Fix-a-make-distcheck-failure.patch
Description: Text Data