Re: EPUB 3.3 spec conformity issues

[Gavin Smith]

On Tue, Aug 20, 2024 at 11:13:59PM +0100, Daniel Cerqueira wrote:
> Thinking more deeply, I have changed the HTML.pm patch.
> 
> The border property of the table element, if set to "1" (instead of ""),
> probably is best for HTML generation, and still produces a valid EPUB
> 3.3.
> 

This can't go in as it is as it adds visible borders to the indices in all
HTML output, not just EPUB3.  There is no good reason to add such borders.

I have checked the rendering with border="" and visibile borders are
also displayed with such an attribute value.  Only with border="0" is
the table rendered with no borders.

According to

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/table#border

the 'border' attribute is deprecated, but we would have to decide whether
we wanted to use CSS instead for this style.

> From a6855aac641d78a781ed720cf070c2b5f07bc449 Mon Sep 17 00:00:00 2001
> From: Daniel Cerqueira <dan.git@lispclub.com>
> Date: Tue, 20 Aug 2024 21:51:19 +0100
> Subject: [PATCH] tp/Texinfo/Convert/HTML.pm: Fix EPUB validity on table border
> 
>  - fix `epubchecker` error thrown on checking for validity of an EPUB
>  file. This addresses the index <table ... border=...> element and
>  property.
> 
> Signed-off-by: Daniel Cerqueira <dan.git@lispclub.com>
> ---
>  tp/Texinfo/Convert/HTML.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tp/Texinfo/Convert/HTML.pm b/tp/Texinfo/Convert/HTML.pm
> index 5901e0db53..81435076d9 100644
> --- a/tp/Texinfo/Convert/HTML.pm
> +++ b/tp/Texinfo/Convert/HTML.pm
> @@ -5978,7 +5978,7 @@ sub _convert_printindex_command($$$$)
>    # now format the index entries
>    $result
>     .= $self->html_attribute_class('table', ["$index_name-entries-$cmdname"])
> -    ." border=\"0\">\n" . '<tr><td></td>'
> +    ." border=\"1\">\n" . '<tr><td></td>'
>      . $self->html_attribute_class('th', ["entries-header-$cmdname"]).'>'
>        # TRANSLATORS: index entries column header in index formatting
>      . $self->convert_tree($self->gdt('Index Entry')) .'</th>'
> -- 
> 2.45.2
>