[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [Patch] new patch for rollback option
From: |
Andre Majorel |
Subject: |
Re: [Bug-wget] [Patch] new patch for rollback option |
Date: |
Tue, 6 Jan 2009 08:07:49 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On 2009-01-06 13:29 +0800, Xin Zou wrote:
> Please help me review this patch for bug20330
> [https://savannah.gnu.org/bugs/index.php?20330].
>
> diff -ru wget.orig/ChangeLog wget/ChangeLog
> --- wget.orig/ChangeLog 2008-12-31 12:39:02.000000000 +0800
> +++ wget/ChangeLog 2009-01-06 12:43:50.000000000 +0800
> @@ -1,3 +1,7 @@
> +2009-01-06 Xin Zou <address@hidden>
> +
> + * configure.ac (AC_CHECK_FUNCS): Added check for truncate.
> +
> 2008-11-10 Micah Cowan <address@hidden>
>
> * MAILING-LIST: Mention Gmane, introduce subsections.
Xin,
your patch has two basic problems :
- it sometimes has spaces where it should have tabs,
- it has the wrong number of spaces, as if your editor had tab
stops at every 4 characters instead of the standard 8 characters.
Look at Changelog with less(1), more(1), or anything that has
standard tab stops and you'll see what I mean.
If your editor is vi, remove ts=4 and expandtab. Also try
:set list
:set listchars=tab:^.,trail:.
That will make the difference between tabs and spaces obvious.
--
André Majorel <URL:http://www.teaser.fr/~amajorel/>