[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Bug #25322

From: David Holman
Subject: Re: [Bug-wget] Bug #25322
Date: Sat, 26 Dec 2009 21:52:16 -0800

The changes in configure.ac were just to make it compile correctly on
my machine, they weren't intended as part of the fix for the bug.
Looking at this a little more closely, it appears that wget actually
does not even update the timestamps correctly on a single file
download via ftp. This execution path goes through
ftp_loop_internal(), but the only place touch() is used (for ftp) is
in ftp_retrieve_list() which is not called for a single-file download.
Perhaps this bug should be fixed first? How does one open new bugs on


On Sat, Dec 26, 2009 at 6:19 AM, Keisial <address@hidden> wrote:
> David Holman wrote:
>> Hi all,
>>   I'm interested in contributing to wget, so I thought 25322 would be
>> a good place to start because it seems like a simple thing to fix.
>> I've attached a diff of code I've written to address this (taken
>> against mainline hg).
> I admit being a complete ignorant regarding automake, but why are you
> doing this?
>> --configure.ac
>>  dnl
>>  dnl Automake setup
>>  dnl
>> -AM_INIT_AUTOMAKE(dist-bzip2 dist-lzma 1.9)
>> In general, how are new options like this named?
>> Is my name acceptable (--match-server-timestamps)?
> Given that the default is to match the server timestamp, I'd call the
> new option
> more like --ignore-server-timestamp
> I also miss the new option at print_help().
>> Is sending patches
>> to this list the best way for me to proceed with bug fixing?
>> Thanks,
>> David
> So says  http://wget.addictivecode.org/HelpingWithWget :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]