Re: [Bug-wget] Wget no_proxy parsing issue

[Giuseppe Scrivano]

Hello Timothy,

this bug is fixed by the commit 2363.  It is present in the last alpha
tarball: ftp://alpha.gnu.org/gnu/wget/wget-1.12-2392.tar.bz2.

Or you can apply this small patch.

=== modified file 'src/host.c'
--- src/host.c  2010-05-08 19:56:15 +0000
+++ src/host.c  2010-05-25 16:36:02 +0000
@@ -874,6 +874,9 @@
   lw = strlen (what);
   for (i = 0; list[i]; i++)
     {
+      if (list[i][0] == '\0')
+        continue;
+
       for (j = strlen (list[i]), k = lw; j >= 0 && k >= 0; j--, k--)
         if (c_tolower (list[i][j]) != c_tolower (what[k]))
           break;

Cheers,
Giuseppe



Timothy Rafael Cardenas2 <address@hidden> writes:

> This is a minor issue with the wget no_proxy env var parsing. If a 
> trailing comma is left on the string containing all addresses not to be 
> used with the proxy server then wget simply reports back with timeout 
> errors. Adding a trailing comma is a common practice in ubuntu and to 
> ensure that this issue does happen again i would imagine a better error 
> message or just a small special case added to the parsing routine of wgets 
> env vars. 
>
>
> no_proxy=localhost,127.0.0.0/8,
>
> wget google.com
> --2010-06-24 09:40:21--  http://google.com/
> Resolving google.com... 209.85.225.105, 209.85.225.106, 209.85.225.147, 
> ...
> Connecting to google.com|209.85.225.105|:80... timeout
>
> no_proxy=localhost,127.0.0.0/8 (notice the missing comma)
>
>
>  wget google.com  
> --2010-06-24 09:48:34--  http://google.com/
> ....
> Saving to: `index.html'
>
>     [ <=>            ] 8,179       --.-K/s   in 0.001s 
>
> 2010-06-24 09:48:34 (9.59 MB/s) - `index.html' saved [8179]
>
> Tim