Re: [Bug-wget] wget alpha release 1.12-2428

[Daniel Stenberg]

On Sun, 3 Oct 2010, Giuseppe Scrivano wrote:

> I have just uploaded a new alpha tarball containing all the recent changes 
> done to wget.

I'm concerned about the large number of warnings I get with a plain stock 
compile with gcc. Like these:

ftp-ls.c: In function 'ftp_parse_unix_ls':
ftp-ls.c:379: warning: 'cur.next' may be used uninitialized in this function
ftp-ls.c:379: warning: 'cur.ptype' may be used uninitialized in this function
ftp-ls.c:379: warning: 'cur.tstamp' may be used uninitialized in this function
ftp-ls.c:108: warning: 'cur.prev' may be used uninitialized in this function
ftp-ls.c:108: warning: 'cur.size' may be used uninitialized in this function

and these:

connect.c:558: warning: dereferencing pointer 'sockaddr' does break 
strict-aliasing rules
connect.c:557: warning: dereferencing pointer 'sockaddr' does break 
strict-aliasing rules
connect.c:544: note: initialized from here
connect.c:575: warning: dereferencing pointer 'sa' does break strict-aliasing 
rules
connect.c:574: note: initialized from here
connect.c: In function 'bind_local':
connect.c:123: warning: dereferencing pointer 'sa' does break strict-aliasing 
rules
connect.c:165: warning: dereferencing pointer 'sa' does break strict-aliasing 
rules
connect.c:165: warning: dereferencing pointer 'sa' does break strict-aliasing 
rules

(using gcc 4.4.5 on a debian unstable)

...

I pulled the latest with bzr just now and ran clang-analyzer on the code base. 
This is the report: http://daniel.haxx.se/wget/2010-10-03-1/

--

 / daniel.haxx.se