[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-wget] Current wget --version is slightly screwy

From: Micah Cowan
Subject: [Bug-wget] Current wget --version is slightly screwy
Date: Sun, 07 Nov 2010 14:42:19 -0800
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20101006 Thunderbird/3.1.5

When I build current wget trunk, --version has:

GNU Wget 1.12-2441 built on linux-gnu.

+digest +https +ipv6 +iri +large-file -md5 +nls -ntlm +opie +ssl/gnutls


Note the -md5, which obviously has to be a lie.

I guess this is because build_info.c.in has:

md5 choice:
    builtin     defined HAVE_BUILTIN_MD5
    openssl     defined HAVE_OPENSSL_MD5
    solaris     defined HAVE_SOLARIS_MD5

but we don't set any of those in configure.ac anymore?

(According to my config.log, it's coming from gnulib, which is what
would've corresponded to "builtin")

I'm guessing we build the md5 component from gnulib unconditionally now,
because it was too much of a pain to maintain that portion of gnulib as
a separate fallback bit.

It's probably a bad idea in general to remove any of the build-info
strings from the --version output, in case someone is using it
programatically (which is what +https was intended for); but this
particular build-info tag was intended more for debugging (i.e., if
there's something broken with MD5 sums, whose implementation are we
using)? So we're probably safe just to ditch it; the other option would
be to hard-code it to "builtin" (if that matches actual fact).

Micah J. Cowan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]