[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Please review my patch for bug #29518

From: Leonard Ehrenfried
Subject: Re: [Bug-wget] Please review my patch for bug #29518
Date: Sun, 6 Feb 2011 22:40:31 +0100


I have improved my patch and it now uses getline() instead of fgets(). This
hopefully corrects the issue of the fixed size of the buffer. I have also
made sure I haven't accidentally edited any files not part of my patch.

The repository is on Launchpad:

As before, please have a look if the code is up to wget standards.

All the best

On Tue, Feb 1, 2011 at 10:26 PM, Leonard Ehrenfried <
address@hidden> wrote:

> Hi,
> I have investigated using readline and it seems to be a library for reading
> from the command line only. I can not for the life of me get it to read from
> a file.
> Is it possible that you meant GNU libc's getline() and not readline()?
> Thanks
> Lenni
> On Sat, Jan 29, 2011 at 9:14 PM, Giuseppe Scrivano <address@hidden>wrote:
>> please add the "readline" module to the list of modules in
>> bootstrap.conf file.  You also need to modify src/Makefile.am, adding
>> $(LIBREADLINE) to LIBS.  All you have to do now is to recall the
>> bootstrap script.  It should work.
>> Cheers,
>> Giuseppe
>> Leonard Ehrenfried <address@hidden> writes:
>> >>
>> >> Where is make looking for the shared libraries? Do I need to set an
>> >> environment variable?
>> >>
>> >
>> > Sorry, I was being a newbie and didn't know that you had to explicitly
>> tell
>> > gcc to open libreadline. Adding -lreadline to the flags compiles it.
>> >
>> > I had a look around Makefile.in to permanently add the compiler flag but
>> to
>> > be honest I'm a little overwhelmed by the size of it.
>> >
>> > How would I go about add the flag?
>> >
>> > Thanks
>> > Lenni

reply via email to

[Prev in Thread] Current Thread [Next in Thread]