[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] set exit code to 1 if invalid host name specified

From: Daniel Manrique
Subject: Re: [Bug-wget] [PATCH] set exit code to 1 if invalid host name specified
Date: Sat, 23 Apr 2011 17:17:00 -0400

Hi Giuseppe,

I've started the assignment process, to at least get the ball rolling,
even if it's not complete in time for the new release.

I've also made the changes you suggested to coding style, and split
the changes into two patches.

Thanks so much for your help and suggestions! Do let me know if more
changes are needd.

- Daniel

On Sat, Apr 23, 2011 at 10:45 AM, Giuseppe Scrivano <address@hidden> wrote:
> Thanks for the patch.  It looks ok but in order to apply it, you need to
> complete the copyright assignments process to the FSF.  We are very
> quite close to have a wget release and I doubt the FSF will receive your
> assignments before it.  Can you please divide your patch in two?  Keep
> changes to the source code in one patch and the new tests in another.
> Please keep the GNU coding style:
> Daniel Manrique <address@hidden> writes:
>> === modified file 'src/html-url.c'
>> --- src/html-url.c    2011-01-01 12:19:37 +0000
>> +++ src/html-url.c    2011-04-23 00:48:22 +0000
>> @@ -810,6 +810,7 @@
>>                       file, url_text, error);
>>            xfree (url_text);
>>            xfree (error);
>> +          inform_exit_status(URLERROR);
> Please maintain the GNU coding style:
>  inform_exit_status (URLERROR);
> Cheers,
> Giuseppe

Attachment: exit-status-when-invalid-host.patch
Description: Text Data

Attachment: tests-exit-status-when-invalid-host.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]