Re: [Bug-wget] [PATCH] Invalid Content-Length header in WARC files, on some platforms

[Tim Ruehsen]

Hey cool, you made these patches so satisfy MS Visual C ???

But if you are in the mood to fix warnings, here are some more ;-)

CFLAGS="-O2 -std=gnu99 -pedantic -Wall -Wstrict-prototypes -Wold-style-
definition -Wmissing-prototypes -Wwrite-strings -Wformat=2 -Wformat -Wformat-
security -Wno-sign-compare -Wextra -D_FORTIFY_SOURCE=2 -Wcast-align -
DNO_C_CTYPE_MACROS"
./configure && make

There are quite some baddies, like
main.c: In function 'main':
main.c:1113:35: warning: ISO C forbids conversion of object pointer to 
function pointer type [-pedantic]
main.c:1604:21: warning: assignment makes integer from pointer without a cast 
[enabled by default]
main.c:1613:4: warning: format '%s' expects argument of type 'char *', but 
argument 7 has type 'int' [-Wformat]
main.c:1615:7: warning: passing argument 1 of 'free' makes pointer from 
integer without a cast [enabled by default]

If you are good, also add -Wconversion
*Some* of these warnings might reveal real problems (most of them not). One 
more reason to write proper code.

And after that, other compilers might even be more verbose.
The clang-analyzer 3.1 also does a pretty good...

;-) I'm am not really serious about that. Don't waste your time.

Regards, Tim