|
From: | Giuseppe Scrivano |
Subject: | Re: [Bug-wget] [PATCH] Invalid Content-Length header in WARC files, on some platforms |
Date: | Mon, 26 Nov 2012 22:50:59 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) |
Ángel González <address@hidden> writes: > On 26/11/12 00:04, Giuseppe Scrivano wrote: >> that is a good idea, we can add something like: >> >> #define MAX_INT_TO_STRING_LEN(x) (sizeof(x) * 24082 / 10000) + 2 >> >> where `x' in our case will be off_t. >> >> I am not sure if such a function already exists somewhere. >> >> Does it improve readability? > Well, that just brings the question «Where does 24082 come from?» but if > that used for eg. > #define STRSIZE_WGINT MAX_INT_TO_STRING_LEN(wgint) > > Then using STRSIZE_WGINT would be more readable :) I think a simple comment can be enough ;) I have pushed the change. Cheers, Giuseppe
[Prev in Thread] | Current Thread | [Next in Thread] |