[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Segmentation fault with current development version of wg

From: Gijs van Tulder
Subject: Re: [Bug-wget] Segmentation fault with current development version of wget
Date: Wed, 01 May 2013 22:34:11 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5

Hi Giuseppe,

Dropping the bit that sanitizes the opt.method is probably a good idea. (Perhaps I shouldn't have replied to your patch directly.)

Still, even if the sanitization is removed: I think it would be better if RESTORE_POST_DATA restores the previous value of opt.method, instead of overwriting it with a hardcoded "POST". Isn't it?

A related question: how is a redirect response to a PUT request handled? How should it be handled?

I haven't tried it, but it looks like in that case the SUSPEND_POST_DATA macro is called (by retrieve_url in retr.c). If that's true, then later on the opt.method would be 'restored' to "POST" by RESTORE_POST_DATA.



Op 01-05-13 22:16 schreef Giuseppe Scrivano:
hi Gijs,

Gijs van Tulder <address@hidden> writes:

Giuseppe Scrivano wrote:
what about this patch?  Any comment?

Another suggestion: why not save the original opt.method, set
opt.method to NULL and put the original opt.method back later?

thanks for your suggestion but I think we should drop the code that
modifies opt.method, since we have to sanitize it only when it is
specified as argument.  Objections?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]