[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Segmentation fault with current development version of wg

From: Darshit Shah
Subject: Re: [Bug-wget] Segmentation fault with current development version of wget
Date: Tue, 7 May 2013 08:26:49 +0530

> We suspend the post data only when we receive a 307, or do you mean we
> shouldn't suspend in this case too?
> It's the other way round. A 307 response code is used when the server
wishes to explicitly ask the client to not suspend. And that is also the
current behaviour.

We currently suspend any method if the response code is a non 307 redirect.
That I believe is wrong. We should only be suspending the POST method and
not others.

> The --method patch has opened a can of worms and now we have to consider
> literally any HTTP method and how it make more sense for the users.
> I think that very few people are going to abuse --method with
> TRACE/OPTIONS and we can consider these cases later, if they really hurt
> someone.  On the other hand, it will be nice to handle separately HEAD.
Well yeah. It has opened a whole lot of possibilities that we must keep
considering. I will handle it separately for HEAD and send in a patch soon.
However, I was thinking, that since the new --method command needs a lot of
work specific to itself and that it may only increase in the future, we
should handle that code separately? Maybe a set_method_opts() function?

Thanking You,
Darshit Shah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]