[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is

From: Giuseppe Scrivano
Subject: Re: [Bug-wget] [PATCH] Regression since wget 1.10: no_prefix function is *bad*
Date: Sun, 12 May 2013 20:22:36 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Tim Rühsen <address@hidden> writes:

> having an abort() without a message is simply a big waste of time for any 
> developer who stumbles upon it.

I disagree here, what is so difficult that a debugger cannot catch?  On
the other hand, I agree this can be improved.

> Since the init code of Wget has to be rewritten anyways, i provide the 
> fastest 
> solution right now: increasing the buffer size and printing a message before 
> Wget aborts.
> And yes, the whole issue is hell stupid...

> -  static char buffer[1024];
> +  static char buffer[2048];

This won't really fix the problem of having a static buffer, the real
fix would be to dynamically allocate the memory.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]