Re: [Bug-wget] Body skipped for non-GET

[Darshit Shah]

>
> Not does it only act differently, but on master it will start looping for
> --tries due to "Connection closed at byte 0. Retrying." which is no more
> than wget itself skipping the full body, then retrying because there's no
> body left.
>
> You are correct. Since I was under the (wrong) idea that a page should not
return a message body to a POST request, I did not include that case in my
manual tests. I have however corrected this issue. This also prevent a
behaviour change against 1.14. Hopefully, everything works smoothly now.


> Hmm. Right. It does what you intended, even if I considered that a bug. We
> need to decide which is the right thing to do, then.
>
I am not sure of the specs, but if servers do respond with a message body,
Wget MUST read it and download it. Hence, I have removed the offending line
of code and will now allow Wget to download the response body.

Is it worth trying to get a test case in the perl ones or should we just
> wait for the python tests?
>
I have already implemented a basic, functioning server in Python for
handling these cases. I have also written tests that test the issues
outlined above and catch them.

I heartily request everyone on this list to identify more Test Cases that
we must check for.
You can checkout the current Test Suite at:
https://github.com/darnir/wget-gsoc


-- 
Thanking You,
Darshit Shah

0001-Download-response-body-data-for-all-requests.patch
Description: Binary data